Skip to content

let devdocs rely ruby 4.0.3,no longer rely ruby 3.x#2680

Open
yzytom wants to merge 7 commits into
freeCodeCamp:mainfrom
yzytom:main
Open

let devdocs rely ruby 4.0.3,no longer rely ruby 3.x#2680
yzytom wants to merge 7 commits into
freeCodeCamp:mainfrom
yzytom:main

Conversation

@yzytom
Copy link
Copy Markdown

@yzytom yzytom commented Apr 21, 2026

If you’re adding a new scraper, please ensure that you have:

  • Tested the scraper on a local copy of DevDocs
  • Ensured that the docs are styled similarly to other docs on DevDocs
  • Added these files to the public/icons/your_scraper_name/ directory:
    • 16.png: a 16×16 pixel icon for the doc
    • 16@2x.png: a 32×32 pixel icon for the doc
    • SOURCE: A text file containing the URL to the page the image can be found on or the URL of the original image itself

If you're updating existing documentation to its latest version, please ensure that you have:

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

@yzytom yzytom requested a review from a team as a code owner April 21, 2026 10:54
@yzytom yzytom force-pushed the main branch 2 times, most recently from 5e5af94 to ac4d05e Compare April 22, 2026 06:47
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 22, 2026 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatedimage_optim_pack@​0.10.1 ⏵ 0.13.1.2026041862 -1310010010070
Updatedthin@​1.8.2 ⏵ 2.0.192 +110010010070 -30
Updatednewrelic_rpm@​8.16.0 ⏵ 10.4.072 +110010010080
Updatedterser@​1.2.6 ⏵ 1.2.796 +110010010080
Updatedactivesupport@​7.2.3 ⏵ 8.1.385 -2100 +4100100100
Updatedthor@​1.4.0 ⏵ 1.5.086 +1100100100100
Updatednokogiri@​1.19.1 ⏵ 1.19.2-aarch64-linux-gnu100 +13100 +1890 -10100100 +31
Updatedrake@​13.3.1 ⏵ 13.4.290100100100100
Updatedimage_optim@​0.31.3 ⏵ 0.31.491 +1100100100100
Updatedminitest@​6.0.2 ⏵ 6.0.591 +1100100100100
Updatedsinatra-contrib@​3.2.0 ⏵ 4.2.195 +1100100100100
Updatedsinatra@​3.2.0 ⏵ 4.2.195 +1100 +3100100100
Updatedrack@​2.2.22 ⏵ 3.2.695 +4100 +31100100100
Updatedrss@​0.3.1 ⏵ 0.3.298 +1100100100100
Addedostruct@​0.6.399100100100100
Updatedbrowser@​5.3.1 ⏵ 6.2.099 +1100100100100
Updatedterminal-table@​3.0.2 ⏵ 4.0.099 +1100100100100
Updatedpry-byebug@​3.11.0 ⏵ 3.12.0100100100100100

View full report

@yzytom yzytom changed the title Ruby 4.X Edition let devdocs rely ruby 4.0.3,no longer rely ruby 3.x Apr 22, 2026
@simon04 simon04 requested a review from Copilot May 29, 2026 20:02
Copilot AI reviewed May 29, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to switch the project from Ruby 3.4.8 to Ruby 4.0.5 across the runtime/version pins and regenerates the Gemfile.lock accordingly. It also constrains html-pipeline to ~> 2.14, explicitly adds ostruct and webrick (libraries that have been extracted from the Ruby stdlib), and adds require 'ostruct' to the images filter test.

Changes:

  • Bump Ruby version pin to 4.0.5 in .ruby-version, Gemfile, Gemfile.lock, Dockerfile, and Dockerfile-alpine.
  • Add ostruct and webrick gem dependencies and constrain html-pipeline to ~> 2.14; regenerate Gemfile.lock (major upgrades of activesupport, sinatra, rack, etc., and platform-specific entries/CHECKSUMS).
  • Add require 'ostruct' to test/lib/docs/filters/core/images_test.rb.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.ruby-version Pins Ruby to 4.0.5.
Gemfile Updates Ruby pin to 4.0.5; adds ostruct and webrick; constrains html-pipeline to ~> 2.14.
Gemfile.lock Regenerated lockfile reflecting new Ruby version, multi-platform entries, CHECKSUMS, and upgraded gems.
Dockerfile Updates base image to ruby:4.0.5.
Dockerfile-alpine Updates base image to ruby:4.0.5-alpine.
test/lib/docs/filters/core/images_test.rb Adds explicit require 'ostruct' to support newer Ruby where it's no longer autoloaded.

Note: Ruby 4.0.5 does not exist as a released version, and no ruby:4.0.5 Docker images are published. The PR title/intent ("rely ruby 4.0.3") is also inconsistent with the actual 4.0.5 pin in the diff. Additionally, .tool-versions (ruby 3.4.8) and README.md (Ruby 3.4.1) still reference older 3.4.x versions and were not updated.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yzytom